-
Notifications
You must be signed in to change notification settings - Fork 37
Claude code guide #1337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Claude code guide #1337
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, added a few minor bits of feedback!
Co-authored-by: Susa Tünker <[email protected]>
Co-authored-by: Susa Tünker <[email protected]>
Co-authored-by: Stefan Judis <[email protected]>
Co-authored-by: Stefan Judis <[email protected]>
Co-authored-by: Stefan Judis <[email protected]>
Co-authored-by: Stefan Judis <[email protected]>
}) | ||
``` | ||
|
||
While you can deploy a Playwright check without a `.check.ts` configuration file, this isn't generally a good practice, as you should at least set the logical ID for your check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a strong statement because it's baked into the checkly.config. However, I'm not sure if we should tell the story of our own options not being the best practice.
|
||
While you can deploy a Playwright check without a `.check.ts` configuration file, this isn't generally a good practice, as you should at least set the logical ID for your check. | ||
|
||
### 2. Add our new Check to Claude's Context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't die on this hill 🫣, but I still don't think this should be a recommendation because it doesn't scale. If we're vibing and we need to tell what to add to the context all the time that's a very manual approach. Having something like
Before creating more check files scan
__checks__
for more info and base setup
is way more scalable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh that's smart. yeah I'll add something like:
Add another line to Claude's context in CLAUDE.md
by entering:
# Before creating more check files scan `__checks__` for more info and base setup
I've left some final niggles would love @Dgiordano33 to have the final saying though. :) |
Co-authored-by: Stefan Judis <[email protected]>
Co-authored-by: Stefan Judis <[email protected]>
Co-authored-by: Stefan Judis <[email protected]>
Co-authored-by: Stefan Judis <[email protected]>
Co-authored-by: Stefan Judis <[email protected]>
Co-authored-by: Stefan Judis <[email protected]>
Co-authored-by: Stefan Judis <[email protected]>
Co-authored-by: Stefan Judis <[email protected]>
Co-authored-by: Stefan Judis <[email protected]>
Affected Components
This guide takes a slightly conservative path through using Claude code for PWT, starting with a codegen test as a model. This path has had good, consistent results for me.